fix(init): remove stale head sha from CI snippets#248
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the now-unused GITHUB_HEAD_SHA from generated CI snippets and updates the scaffolded/generated lint workflow to pass the GitHub env vars Flint’s link-remap logic actually consumes.
Changes:
- Update the init scaffold template for
.github/workflows/lint.ymlto stop exportingGITHUB_HEAD_SHAand exportGITHUB_REPOSITORY,GITHUB_BASE_REF,GITHUB_HEAD_REF, andPR_HEAD_REPOinstead (plusGITHUB_TOKEN). - Extend the init workflow-generation test to assert the new env vars are present and
GITHUB_HEAD_SHAis absent. - Update README and this repo’s lint workflow to match the new recommended env set.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/init/tests.rs |
Adds assertions for the new workflow env vars and verifies GITHUB_HEAD_SHA is no longer emitted. |
src/init/scaffold.rs |
Updates the generated lint.yml template env block to match Flint’s current GitHub link-remap inputs. |
README.md |
Updates the CI snippet and explanation to remove GITHUB_HEAD_SHA and document the new env vars. |
.github/workflows/lint.yml |
Aligns the repo’s own lint workflow with the new env vars used by Flint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martincostello
approved these changes
Apr 28, 2026
This was referenced May 8, 2026
Closed
Merged
zeitlinger
pushed a commit
that referenced
this pull request
May 11, 2026
## 🤖 New release * `flint`: 0.21.0 -> 0.22.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.22.0](v0.21.0...v0.22.0) - 2026-05-11 ### Added - replace codespell with typos ([#269](#269)) - *(lychee)* add local cache for local runs ([#268](#268)) ### Fixed - *(renovate-deps)* surface real renovate failure in error output ([#278](#278)) - *(ci)* drop double release-plz update from release:pr ([#276](#276)) - *(init)* normalize node runtime before linters ([#267](#267)) - *(renovate)* support block-scalar mise sha256 values ([#266](#266)) - *(mise)* migrate flint-managed tools to supported backends ([#258](#258)) - validate renovate dependency rule coverage ([#263](#263)) - make flint-setup state-based ([#252](#252)) - *(init)* let rustfmt own Rust line length ([#250](#250)) - run renovate-deps for deleted tracked files ([#247](#247)) - validate CI env and isolate check types ([#253](#253)) - *(init)* remove stale head sha from CI snippets ([#248](#248)) - *(init)* enable yamllint indentation rule ([#251](#251)) ### Other - streamline README getting started ([#280](#280)) - *(deps)* update taiki-e/install-action digest to fa0dd4c ([#282](#282)) - *(deps)* lock file maintenance ([#285](#285)) - *(deps)* update dependency mise to v2026.5.2 ([#284](#284)) - *(deps)* update dependency go to v1.26.3 ([#283](#283)) - *(deps)* update taiki-e/install-action digest to e3134ec ([#281](#281)) - pass git-token and forge to release-plz ([#274](#274)) - *(deps)* update taiki-e/install-action digest to 3fa6878 ([#275](#275)) - *(deps)* bump renovate to 43.150.0 ([#273](#273)) - [**breaking**] drop --fast-only flag and tighten renovate-deps timing ([#270](#270)) - *(deps)* update rust crate tokio to v1.52.2 ([#272](#272)) - upgrade lychee to v0.24.2 ([#265](#265)) - *(deps)* update taiki-e/install-action digest to cca35ed ([#254](#254)) - *(deps)* update dependency aqua:owenlamont/ryl to v0.8.0 ([#261](#261)) - *(deps)* update dependency mise to v2026.4.28 ([#262](#262)) - *(deps)* update dependency golangci-lint to v2.12.1 ([#264](#264)) - *(deps)* update dependency aqua:owenlamont/ryl to v0.7.0 ([#259](#259)) - *(renovate)* simplify quickstart and batch weekly linter updates ([#257](#257)) - *(deps)* update dependency npm:renovate to v43.141.6 ([#255](#255)) - expand positioning and comparisons ([#239](#239)) - *(deps)* update taiki-e/install-action digest to 1f2425c ([#246](#246)) - move release-plz flow into mise tasks ([#234](#234)) - *(deps)* update taiki-e/install-action digest to 481c34c ([#231](#231)) - *(deps)* update dependency ruff to v0.15.12 ([#245](#245)) - *(deps)* update dependency npm:renovate to v43.141.5 ([#244](#244)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops generated CI snippets and docs from exporting
GITHUB_HEAD_SHA, which Rust Flint no longer reads.The generated workflow now passes the GitHub link-remap environment Flint actually uses:
GITHUB_REPOSITORY,GITHUB_BASE_REF,GITHUB_HEAD_REF,PR_HEAD_REPO, andGITHUB_TOKEN, while keepingfetch-depth: 0.The missing-env failure/warning is intentionally deferred.
Validation
cargo fmtcargo test generate_lint_workflowmise run lint:fixgit diff --check